This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] 16 bit real-mode for the i386


Andrew Cagney <ac131313@ges.redhat.com> writes:


Hello,

The attached modifies i386-tdep.c so that there is a ``set i386 real-mode'' command (doco to go).

When real-mode is enabled, GDB computes the ``20 bit'' ``stop address'' (aka PC but not to be confused with $pc ... :-) from both the $cs and $pc registers. That way, core GDB sees a cannonical PC address that (regardless of $cs) will match a ``20 bit'' breakpoint address.

Thoughts?

Looks OK to me.  Just two nits: could you consider
s/CS_REGNUM/I386_CS_REGNUM/?  And I believe the GNU coding standards
say that one shouldn't introduce unecessary whitespace.  Therefore I
have some problems with the extra newlines you're introducing.
I'll change the macro^D^Denum. Many of the new lines are consistent with whats around (but I'll prune those that look excessive little).

Are you planning to add this before we cut the branch?  I'm a little
uncomfortable with adding any new features just before doing so.
I'm not expecting to really follow this up until after the branch is cut. (And I still need to think up a testcase :-)

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]