This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfc] Don't complain about unknown OSABI
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Andrew Cagney <ac131313 at ges dot redhat dot com>
- Cc: Jason R Thorpe <thorpej at wasabisystems dot com>,gdb-patches at sources dot redhat dot com
- Date: Sun, 18 Aug 2002 11:50:45 -0400
- Subject: Re: [patch/rfc] Don't complain about unknown OSABI
- References: <3D5FC00D.50001@ges.redhat.com>
Andrew Cagney writes:
> Hello,
>
> The attached patch removes the warning message that is printed when the
> OSABI is unknown (all the sniffers failed).
>
> When debugging an embedded executable, there is no OSABI info. Hence I
> don't think the warning should be issued. This can be seen when
> debugging a GCC created, mips-elf executable.
>
> thoughts?
Yes. I am hitting this on powerpc with the e500 port. It also makes
the testsuite fail in some spots. So, I like it.
Thanks.
Elena
> Andrew
> 2002-08-18 Andrew Cagney <ac131313@redhat.com>
>
> * osabi.c (gdbarch_init_osabi): Don't complain about an unknown
> ABI.
>
> Index: osabi.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/osabi.c,v
> retrieving revision 1.5
> diff -u -r1.5 osabi.c
> --- osabi.c 27 Jul 2002 01:28:43 -0000 1.5
> +++ osabi.c 18 Aug 2002 13:53:49 -0000
> @@ -232,13 +232,8 @@
>
> if (osabi == GDB_OSABI_UNKNOWN)
> {
> - /* Don't complain about not knowing the OS ABI if we don't
> - have an inferior. */
> - if (info.abfd)
> - fprintf_filtered
> - (gdb_stderr, "GDB doesn't recognize the OS ABI of the inferior. "
> - "Attempting to continue with the default %s settings",
> - bfd_printable_arch_mach (arch_info->arch, arch_info->mach));
> + /* Don't complain about not knowing the OS ABI. Assume the user
> + knows what they are doing. */
> return;
> }
>