Re: [rfa/testsuite] more tests in gdb.c++/m-static

[Daniel Jacobowitz <drow at mvista dot com>]

On Fri, Aug 16, 2002 at 02:19:35PM -0700, David Carlton wrote:
> I've added some tests to gdb.c++/m-static that correspond to the patch
> in <http://sources.redhat.com/ml/gdb-patches/2002-08/msg00385.html>;
> patches below.
> 
> A few tangential questions:
> 
> * I hope I got the stuff in brackets in the subject correct; is rfa
>   "request for approval"?

Yup.  You might want to specify c++testsuite and/or CC the various
testsuite maintainers.

> * What's the convention for submitting new files (as opposed to
>   patches to existing files)?  (I'd look through the mail archive for
>   examples, but I don't seem to be able to access it right now.)  I'm
>   attaching them below as files and hoping that the mailer will make
>   it clear what they're named and so forth; please let me know if I
>   should do anything else.

I usually use diff -N to do this.

> * CONTRIBUTE suggests using "cvs diff -cp", but everybody submits
>   unidiff patches.  Should I change it to say "cvs diff -up"?

Either works.  I like unidiff, personally.

> * Does "make clean" actually clean up the testsuite directory
>   properly?  Looking at the Makefile in gdb.c++, it seems like it
>   cleans up whatever's in the EXECUTABLES variable, which certainly
>   doesn't include all the executables in that directory.  Is there
>   something else magic going on, or should I audit the Makefile.in's
>   in the various directories to see if they clean up everything?
>   (Yes, I know, I should really type "make clean" and see what it
>   does, but I don't feel like rebuilding gdb if somebody can answer
>   the question quickly.)

No, the testsuite directory doesn't get cleaned properly.  I recommend
using a separate object directory anyway; it keeps things neater.

Oh, and you might want to use namespace names that aren't in the
implementation space (__gnu is in the implementation space, because it
starts with two underscores.  _[A-Z] is also reserved.)

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer