This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Add declaration in i386-tdep.h (for interix)


Joel Brobecker <brobecker@gnat.com> writes:

> Hello Mark,
> 
> I submitted this change, motivated by the fact that the interix-tdep
> file needs this declaration. Andrew suggested that we namespace-proof
> this function. I would be glad to change the name to, say,
> 
>     i386_skip_trampoline_code
> 
> But I would perfer to have your opinion/approval before going ahead,
> since you are the i386 maintainer.

Hmm, somehow this escaped from my attention.  Sorry 'bout that.

Andrew's suggestion is a good one.  However, since the code is
WIN32/PE-specific I'd prefer,

   i386_win32_skip_trampoline_code

or

   i386_pe_skip_trampoline_code

Consider the resulting patch pre-approved.

Thanks,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]