This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Mips, return_value_location, small structs


Andrew Cagney wrote:
> 
> > Andrew Cagney wrote:
> >
> >>
> >
> >> > Re-submitted as a separate patch.
> >> >
> >> > The problem: small structs returned in one (or two) registers
> >> > are aligned left in N32/N64 and aligned right in the others
> >> > (or vice versa, depending on how you cross your eyes).
> >
> >>
> >> I _think_ you also need to add o32.  Can you check that out?  Just post
> >> the results, not the patch.
> >
> >
> > I know o32 needs work too, but the two can be treated separately.
> > I do guarantee that this patch does not make o32 any worse.
> > In fact, I have been testing to make sure that none of my patches
> > have made o32 any worse.
> >
> > Can I check this one in for n32, if I promise to work on o32 next?
> 
> Why not just fix this bug for all three ABIs?  o32 is just like n32/n64
> in that it cross-eyes the arguments.

Andrew, o32 works as it is.  I can't find anything related to this
patch that still needs to be done for o32.  Unles you can suggest
something specific, may I check this patch in?

Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]