This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] procfs.c: TARGET_CAN_USE_HARDWARE_WATCHPOINT via targetvector


On Aug 13,  5:11pm, Andrew Cagney wrote:


> +#ifndef TARGET_HAS_HARDWARE_WATCHPOINTS


I just think the macro should be `largely' renamed: ``PROCFS_HAS_HARDWARE_WATCHPOINTS''.

Largely? There are a few exceptions -- i386v-nat.c and mips/tm-embed.h which could be left alone.

For the procfs related uses, I suspect that we can eliminate the use
of the macro altogether.  (I'd prefer to get Michael's opinion though
before attempting such a change.)
That would be even better! I'm just trying to ensure that someone doesn't try to sneak in a reference to ..._HAS_HARDWARE_WATCHPOINTS where they shouldn't (ie. outside of procfs.c :-).

enjoy,
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]