This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [Fwd: gcore for netbsd]
Andrew Cagney wrote:
>
> > Andrew Cagney wrote:
> >
> >>
> >> Hello,
> >>
> >> This patch has made me wonder why gcore even includes <sys/procfs.h>.
> >
> >
> > I'm guessing it went in before I split some code out into linux-proc.c.
> >
> >
> >
> >> Can anyone think of a reason for not simply removing the include?
> >
> >
> > Try it and see...
>
> Going going ....
>
> >> I'm also wondering what the function preempt_derive_stack_segment() is
> >> for. I can't find any callers.
> >
> >
> > Probably for future use -- for systems where the default method didn't
> > work, or where there was a more efficient method available.
>
> It can't be a global though. That is going to be very multi-arch /
> multi-target unfriendly.
>
> Mind if that gets removed as well? As it is, it is wrong.
Sure, go ahead.