This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit
Kevin Buettner wrote:
>
> On Jul 31, 3:44pm, Michael Snyder wrote:
>
> > > * mips-tdep.c (mips_push_arguments): Don't assume that
> > > ``MIPS_SAVED_REGSIZE < 8'' means that the o64 abi is in use.
> > > Instead, test for it explicitly.
> >
> > Kevin,
> >
> > This change makes things worse for N32. I haven't tested
> > N64 yet. I think we're gonna have to look at these lines
> > from the perspective of all 3 (6) abis.
>
> Okay, this patch is withdrawn while I retest...
>
> To save some time, can you tell me which N32 regressions you see?
Buncha failures in structs.exp.
If you have a look at the tweak that I sent, it might be the thing.