This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fourth and last patch to aix-thread.c


On Jul 19,  3:46pm, Michael Snyder wrote:

> This is the last one, I promise.  I thought some of the identifiers in
> aix-thread
> were a little un-informative and/or inconsistant with other target
> modules, so
> I offer you this renaming.
> 
> And I humbly beg your pardon, but I was unable to resist sneaking a few
> whitespace clean-ups in there too.  If you like, I'll re-submit them 
> separately.
[...]
> 	* aix-thread.c (ops): Rename to pthdebug_ops.
> 	(base_ops): Rename to base_target.
> 	(ops_attach): Rename to pthdebug_attach.
> 	(ops_detach): Rename to pthdebug_detach.
> 	(ops_resume): Rename to pthdebug_detach.
> 	(ops_wait):   Rename to pthdebug_wait.
> 	(ops_kill):   Rename to pthdebug_kill.
> 	(init_ops):   Rename to init_pthdebug_ops.
> 	(ops_fetch_register): Rename to pthdebug_fetch_register.
> 	(ops_store_register): Rename to pthdebug_store_register.
> 	(ops_mourn_inferior): Rename to pthdebug_mourn_inferior.
> 	(ops_thread_alive):   Rename to pthdebug_thread_alive.
> 	(ops_extra_thread_info: Rename to pthdebug_extra_thread_info.
> 	(ops_pid_to_str):  Rename to pthdebug_pid_to_str.
> 	(ops_xfer_memory): Rename to pthdebug_xfer_memory.
> 	(fetch_regs_lib):  Rename to fetch_regs_user_thread.
> 	(fetch_regs_kern): Rename to fetch_regs_kernel_thread.
> 	(store_regs_lib):  Rename to store_regs_user_thread.
> 	(store_regs_kern): Rename to store_regs_kernel_thread.

I've check this in with a couple of modifications:

    1) I used ``aix_thread_'' instead of ``pthdebug_''.  If you check
       lin-lwp.c and thread-db.c, the use of ``aix_thread'' more closely
       corresponds (IMO) to what's done in those files.

    2) I fixed up a few places where a substition was missed.

Michael, thanks for all the work you did in reviewing and cleaning up
this code.  I really appreciate it.

(Now that I've been away from it for a few days and looked at it again,
I've found a few more things that I want to clean up...)

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]