Re: [RFA] Avoid Cannot read 0x20000000 on cygwin GDB

[Elena Zannoni <ezannoni at redhat dot com>]

Pierre Muller writes:
 > This has been discuss long ago, 
 > and I thought it was in CVS already for a long time,
 > but apparently noone committed it.
 > 
 > Back in september 200, I probably didn't dare to commit it myself,
 > but my commit list grew quite a lot since that time!
 > 
 > See http://sources.redhat.com/ml/gdb-patches/2000-09/msg00107.html
 > 
 > If I get an second approval from 
 > any of the Blanket Write Privs (as blockframe.c 
 > does not seem to belong to some designated group),
 > I will commit this ASAP.
 > 
 > ChangeLog entry:
 > 
 > 2000-09-12  Pierre Muller  <muller@ics.u-strasbg.fr>
 > 	* blockframe.c (get_pc_function_start): return 0 if the minimal symbol
 > 	found is not inside a section.
 > 

Go ahead. Check it in. It was already approved, back in 2000.

Elena



 > 
 > 
 > $ cvs diff -u -p blockframe.c
 > Index: blockframe.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/blockframe.c,v
 > retrieving revision 1.32
 > diff -u -p -r1.32 blockframe.c
 > --- blockframe.c        2 Jul 2002 19:08:55 -0000       1.32
 > +++ blockframe.c        15 Jul 2002 14:13:32 -0000
 > @@ -632,6 +632,8 @@ get_pc_function_start (CORE_ADDR pc)
 >     else if ((msymbol = lookup_minimal_symbol_by_pc (pc)) != NULL)
 >       {
 >         fstart = SYMBOL_VALUE_ADDRESS (msymbol);
 > +      if (!find_pc_section (fstart))
 > +       return 0;
 >       }
 >     else
 >       {
 > 
 > 
 > 
 > Pierre Muller
 > Institut Charles Sadron
 > 6,rue Boussingault
 > F 67083 STRASBOURG CEDEX (France)
 > mailto:muller@ics.u-strasbg.fr
 > Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99