This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: Fix bug gdb/321
On Thu, Jul 11, 2002 at 09:30:10PM +0200, Corinna Vinschen wrote:
> On Thu, Jul 11, 2002 at 02:56:03PM -0400, Daniel Jacobowitz wrote:
> > On Thu, Jul 11, 2002 at 08:52:08PM +0200, Corinna Vinschen wrote:
> > > Hi,
> > >
> > > the following patch seems to fix the bug described in gdb/321:
> > >
> > > http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=321
> > >
> > > Basically the problem is that gdb's backtrace reports the wrong calling
> > > function if a function ends in a call to abort() (or another noreturn func)
> > > under some conditions. The bug report suggests to use a by one decremented
> > > pc when evaluating the function. The following patch does exactly this by
> > > using the return value of frame_address_in_block() instead of frame->pc in
> > > calls which evaluate symbols.
> >
> > FWIW, I think this is perfect - thanks!
>
> Applied.
For the record, I can't approve patches - although this one was fairly
obvious, so I don't think anyone will complain.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer