This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gdbserver for x86-64


On Thu, Jul 04, 2002 at 08:04:46AM +0200, Michal Ludvig wrote:
> Daniel Jacobowitz wrote:
> >On Wed, Jul 03, 2002 at 04:40:58PM +0200, Michal Ludvig wrote:
> >>2002-07-03  Michal Ludvig  <mludvig@suse.cz>
> >>
> >>	* gdbserver/linux-x86-64-low.c (x86_64_fill_gregset): Change type in 
> >>	explicit cast to CORE_ADDR so that pointer arithmetic works.
> >>	(x86_64_store_gregset): Ditto + parameter made const.
> >>	(x86_64_store_fpregset): Parameter made const.
> >
> >
> >Could you change the reg_map instead, please?  It's used outside of
> >this file and expected to be in byte offsets. 
> 
> Where is it used? It seems to be a static array without any reference 
> from outside.

Oh, you're right.  Because x86-64 only uses GETREGS, it doesn't expose
the regmap.

> >Just add *4 or *8 where appropriate as I did in the i386 file.
> 
> OK, changed and committed as in the attached file.

Thanks!

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]