Re: RFA: don't xfail ptype test

[Jim Blandy <jimb at redhat dot com>]

Michael Elizabeth Chastain <mec@shout.net> writes:
> This patch is returned for more work.
> 
> Hmmm.  I agree that this is a bug:
> 
>   (gdb) ptype &*"foo"
>   type = char [4]
> 
> I get that behavior in all of my configurations.
> 
> The problem is simply converting XFAIL -> FAIL.  That's correct, but it
> doesn't leave a good enough trail for people doing regression analysis.
> 
> Could you please file a bug report and then add a comment to the
> test script with the bug ID number in it:
> 
>   # setup_kfail "gdb/1234"
> 
> The bug report can say that this bug is also present in 5.2.
> 
> I am willing to file the bug report this evening if you want me to
> do that part.
> 
> Michael C

Okay, how's the below?  What's setup_kfail?  Where can I find a
description of it?

2002-05-10  Jim Blandy  <jimb@redhat.com>

	* gdb.base/printcmds.exp: Don't xfail the ptype command.  This is
	a bug.

Index: gdb/testsuite/gdb.base/printcmds.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/printcmds.exp,v
retrieving revision 1.7
diff -c -r1.7 printcmds.exp
*** gdb/testsuite/gdb.base/printcmds.exp	4 May 2002 15:18:21 -0000	1.7
--- gdb/testsuite/gdb.base/printcmds.exp	10 May 2002 18:05:04 -0000
***************
*** 626,633 ****
      gdb_test "ptype \"foo\""		" = char \\\[4\\\]"
      gdb_test "p *\"foo\""		" = 102 'f'"
      gdb_test "ptype *\"foo\""		" = char"
      gdb_test "p &*\"foo\""		" = \"foo\""
-     setup_xfail "*-*-*"
      gdb_test "ptype &*\"foo\""	"type = char \\*"
      gdb_test "p (char *)\"foo\""	" = \"foo\""
  }
--- 626,633 ----
      gdb_test "ptype \"foo\""		" = char \\\[4\\\]"
      gdb_test "p *\"foo\""		" = 102 'f'"
      gdb_test "ptype *\"foo\""		" = char"
+     # setup_kfail "gdb/538"
      gdb_test "p &*\"foo\""		" = \"foo\""
      gdb_test "ptype &*\"foo\""	"type = char \\*"
      gdb_test "p (char *)\"foo\""	" = \"foo\""
  }