This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: printing java `char' values


Daniel Jacobowitz wrote:
> 
> On Wed, May 08, 2002 at 01:57:21PM -0700, Michael Snyder wrote:
> > I'd prefer not to perpetuate TYPE_CODE_CHAR.  This seems to have been
> > a one-time thing, and not (I think) a good idea.  In general if GDB
> > wants to know if two things can be added or XOR'd or something, it
> > only needs to check to see if they are TYPE_CODE_INT, (because chars
> > are really ints of size 1).  This should have been implemented as a
> > TYPE_FLAG_*, not a TYPE_CODE-*.
> 
> Sounds good to me.  Would you be interested in patches which actually
> change TYPE_CODE_CHAR to TYPE_FLAG_CHAR, if it's practical?

Uhh, sure.  That would be a non-trivial change, and it might take
a little effort to verify that it was transparent... but I think
the idea is good (quite apart from the fact that I thought of it <g>)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]