This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: test for GDB C++ STABS problem



Michael Elizabeth Chastain <mec@shout.net> writes:
> This patch is approved, with one optional change request.  That is to say,
> you can commit it as is, or you can make the change.
> 
> The optional change is to add an initialization for "var_in_b"
> to a nonzero value such as 100.  That way, the test is less likely 
> to succeed by accident.  I tried this and it did not affect the
> test results.

Well, we're really testing that the command completes at all, not that
it does anything in particular before it returns.  But you're right
that zero is an inauspicious value; I've made the change, and
committed the patch.

> As always, I appreciate your essays in the comment section.

It's nice to know somebody reads them!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]