Re: [RFA] patch to testsuite/config/sid.exp

[Michael Snyder <msnyder at redhat dot com>]

Ben Elliston wrote:
> 
> The following patch (submitted on behalf of Graydon Hoare) adds
> support for testing GDB on SID simulators using a new mode of
> invocation.  Okay to commit?
> 
> Ben

It all looks ok to me, except I have a question about...

> 
> 2002-02-14  Graydon Hoare  <graydon@redhat.com>
> 
>         * config/sid.exp: Include support for "rawsid" protocol.
> 
> Index: config/sid.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/config/sid.exp,v
> retrieving revision 1.25
> diff -u -p -r1.25 sid.exp
> --- sid.exp     2002/04/05 23:31:59     1.25
> +++ sid.exp     2002/04/29 22:16:49
> @@ -53,6 +53,8 @@ proc sid_start {} {
>         }
>         if { [board_info target sim,protocol] == "sid" } {
>             set spawncmd "[target_info sim] [target_info sim,options] $sidendian2 -e \"set cpu-gdb-socket sockaddr-local 0.0.0.0:$port\""
> +       } elseif { [board_info target sim,protocol] == "rawsid" } {
> +           set spawncmd "[target_info sim] [target_info sim,options] -$sidendian --gdb=$port"
>         } else {
>             set spawncmd "../../sid/bsp/[target_info sim] $sidendian --gdb=$port [target_info sim,options]"

one of the diffs between these two spawncmds, namely, that the old one
specifies a path before [target_info sim], but your new one doesn't.

Is that intentional?

>         }
> @@ -67,6 +69,8 @@ proc sid_start {} {
>             # FIXME: sim,options may be from the build tree, should find
>             # it in the install tree.
>             set spawncmd "sid [target_info sim,options] $sidendian2 -e \"set cpu-gdb-socket sockaddr-local 0.0.0.0:$port\""
> +       } elseif { [board_info target sim,protocol] == "rawsid" } {
> +           set spawncmd "[target_info sim] [target_info sim,options] -$sidendian --gdb=$port"
>         } else {
>             set spawncmd "[target_info sim] $sidendian --gdb=$port [target_info sim,options]"
>         }