This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA 2nd] hpread.c printf (stderr,... ->fprintf_unfiltered (gdb_stderr,..
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Pierre Muller <muller at cerbere dot u-strasbg dot fr>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 26 Apr 2002 09:32:38 -0400
- Subject: Re: [RFA 2nd] hpread.c printf (stderr,... ->fprintf_unfiltered (gdb_stderr,..
- References: <4.2.0.58.20020426105725.0233c338@ics.u-strasbg.fr>
> in hpread.c
> there is a line with
> #include "syms.h"
> but there is no syms.h
> in the gdb sources...
>
> If I do a 'grep -n syms.h *.c in gdb directory,
> I get only this:
> $ grep -n syms.h *.c
> hpread.c:29:#include "syms.h"
> somread.c:25:#include <syms.h>
>
> Is the hpread.c file obsolete?
> Or shouldn't it be also
> #include <syms.h>
> like in somread.c?
I need to tread carefuly here, skating on thin ice :-) There is the
strict ISO C defined behavour of "" vs <> and then there are accepted
conventions (note plural).
Within GDB, the accepted convention is to use <> as as "syms.h" is a
system header.
In theory, it should be possible for you to compile hpread.c on any
system, because of includes like the above, it isn't (hence the
MAINTAINERS file marks it as broken). Consequently, yes, ok.
Andrew