This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix bug report #508


On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
> This is a fix (allmost obvious) to
> the  bug report #508.
> 
> 
> ChangeLog entry:
> 
> 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.

I'd call this obvious, actually.  Please commit it (but add 'Fix PR
gdb/508' above '* symfile.c' in your changelog).

> $ cvs diff -u -p -N symfile.c
> Index: symfile.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/symfile.c,v
> retrieving revision 1.59
> diff -u -p -r1.59 symfile.c
> --- symfile.c   22 Apr 2002 10:19:35 -0000      1.59
> +++ symfile.c   24 Apr 2002 22:24:14 -0000
> @@ -1831,8 +1831,9 @@ add_filename_language (char *ext, enum l
>     if (fl_table_next >= fl_table_size)
>       {
>         fl_table_size += 10;
> -      filename_language_table = xrealloc (filename_language_table,
> -                                         fl_table_size);
> +      filename_language_table =
> +       xrealloc (filename_language_table,
> +                 fl_table_size * sizeof (*filename_language_table));
>       }
> 
>     filename_language_table[fl_table_next].ext = xstrdup (ext);
> 
> 
> 
> Pierre Muller
> Institut Charles Sadron
> 6,rue Boussingault
> F 67083 STRASBOURG CEDEX (France)
> mailto:muller@ics.u-strasbg.fr
> Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
> 

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]