This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Improve Sparc epilogue analysis


   From: Michael Snyder <msnyder@redhat.com>
   Date: Wed, 24 Apr 2002 16:14:56 -0700

   In this case, I don't believe you got the frameless_p case 
   right.  First, you don't seem to have changed the definition
   of SKIP_PROLOGUE_FRAMELESS_P in tm-sparc.h.  Second, your
   implementation of sparc_prologue_frameless_p is not 
   functionally equivalent to the old one.  If it goes thru
   the new, symbolic path, it will not return the same result.
   
SKIP_PROLOGUE_FRAMELESS_P died within the past day or two from the
whole GDB tree, perhaps you didn't notice :-)

Specifically, here:

2002-04-21  David S. Miller  <davem@redhat.com>

        * arch-utils.c (generic_prologue_frameless_p): Kill
        SKIP_PROLOGUE_FRAMELESS_P code.
        * config/arc/tm-arc.h (SKIP_PROLOGUE_FRAMELESS_P): Delete
        references.
        (PROLOGUE_FRAMELESS_P, arc_prologue_frameless_p): New.
        * arc-tdep.c (arc_prologue_frameless_p): Implement.
        * config/arc/tm-sparc.h (SKIP_PROLOGUE_FRAMELESS_P): Delete
        references.
        (PROLOGUE_FRAMELESS_P, sparc_prologue_frameless_p): New.
        * sparc-tdep.c (sparc_prologue_frameless_p): Implement.
        (sparc_gdbarch_init): Pass it to
        set_gdbarch_prologue_frameless_p.

Posted here:

	http://sources.redhat.com/ml/gdb-patches/2002-04/msg00727.html

I'd like to ask that you re-review this change, given this, please.

Thank you.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]