This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] More tweaks to arm_skip_prologue
- From: Michael Snyder <msnyder at redhat dot com>
- To: Richard dot Earnshaw at arm dot com
- Cc: Michael Snyder <msnyder at cygnus dot com>, gdb-patches at sources dot redhat dot com, cagney at redhat dot com, rearnsha at arm dot com
- Date: Wed, 24 Apr 2002 11:35:12 -0700
- Subject: Re: [RFA] More tweaks to arm_skip_prologue
- Organization: Red Hat, Inc.
- References: <200204240922.KAA26547@cam-mail2.cambridge.arm.com>
Richard Earnshaw wrote:
>
> > Richard Earnshaw wrote:
> > [...]
> > > This should only ever be "str lr, [sp, #-4]!" (note the writeback).
> >
> > Richard, how's this revised patch?
> >
> > Do you think that, if we detect the str lr, [sp, -4]!
> > we should just return pc + 4 immediately?
>
> Well, there could be some stack allocation (and maybe some stores to it),
> there might, in theory, be some floating point stacking as well.
>
> >
> > 2002-04-22 Michael Snyder <msnyder@redhat.com>
> >
> > * arm-tdep.c (arm_skip_prologue): Better handling for frameless
> > functions. Treat "mov ip, sp" as optional. Recognize
> > "str lr, [sp, #-4]".
>
> Working on the principal that this is better than what we have, I think
> this should go in. More needs to be done, but I don't think it should
> block this change.
Great, that's what I hoped for.
I will be doing some more work on this code, so if you
want to continue sending suggestions... ;-)