Re: [PATCH] Add overlay event support to testcase.

[Michael Snyder <msnyder at redhat dot com>]

Andrew Cagney wrote:
> 
> > 2002-04-04  Michael Snyder  <msnyder@redhat.com>
> >
> > * gdb.base/ovlymgr.c: Add overlay event breakpoint support.
> 
> Will adding this mean that the event-breakpoint mechanism is the only
> one tested?

Hmmm, good question.  I guess it will.
Should I clone the test case so we test both?


> 
> Andrew
> 
> > Index: gdb.base/ovlymgr.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ovlymgr.c,v
> > retrieving revision 1.2
> > diff -c -3 -p -r1.2 ovlymgr.c
> > *** ovlymgr.c 2002/02/05 03:44:25     1.2
> > --- ovlymgr.c 2002/04/04 19:47:38
> > *************** FlushCache (void)
> > *** 30,35 ****
> > --- 30,44 ----
> >   #endif
> >   }
> >
> > + /* _ovly_debug_event:
> > +  * Debuggers may set a breakpoint here, to be notified
> > +  * when the overlay table has been modified.
> > +  */
> > + static void
> > + _ovly_debug_event (void)
> > + {
> > + }
> > +
> >   /* OverlayLoad:
> >    * Copy the overlay into its runtime region,
> >    * and mark the overlay as "mapped".
> > *************** OverlayLoad (unsigned long ovlyno)
> > *** 57,63 ****
> >            _ovly_table[ovlyno][SIZE]);
> >
> >     FlushCache ();
> > !
> >     return TRUE;
> >   }
> >
> > --- 66,72 ----
> >            _ovly_table[ovlyno][SIZE]);
> >
> >     FlushCache ();
> > !   _ovly_debug_event ();
> >     return TRUE;
> >   }
> >
> > *************** OverlayUnload (unsigned long ovlyno)
> > *** 80,85 ****
> > --- 89,95 ----
> >            _ovly_table[ovlyno][VMA],
> >            _ovly_table[ovlyno][SIZE]);
> >
> > +   _ovly_debug_event ();
> >     return TRUE;
> >   }
> >
> >