This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: add set cp-abi command


On Wed, Mar 20, 2002 at 07:01:53PM -0800, Jim Ingham wrote:
> >With the above changes it should be OK, although I would like to see
> >it.  Thanks for following this through.
> 
> Okay, let's see what Mail.app thinks is an attachment...

Not too bad, although I wish it knew how to mark them inline... in any
case, if you'll fix two tiny things this is approved.

!   char *longname; /* These two can't be const, because I need to */
!   char *doc;      /* change the name for the auto abi. */   

Comment formatting is against the GNU standard... I'd rather you just
kill the comment.

+                "Set the ABI used for inspecting C++ objects.\n\
+ \"set cp-abi\" with no arguments will list the available ABIs.", &setlist);

Replace with:
+                "Set the ABI used for inspecting C++ objects.\n"
+ 		 "\"set cp-abi\" with no arguments will list the available ABIs.",
+		 &setlist);

(or something like that; eliminating the \-return, which gcc3 I thought
would warn about...)

OK to commit with those changes.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]