This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [MIPS sim PATCH] Remove SIGNEXTEND.
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: cgd at broadcom dot com
- Cc: cagney at redhat dot com, gdb-patches at sources dot redhat dot com
- Date: Tue, 05 Mar 2002 14:18:34 -0500
- Subject: Re: [MIPS sim PATCH] Remove SIGNEXTEND.
- References: <yov5y9h6sufq.fsf@broadcom.com>
> Hi Andrew, want your opinion as MIPS sim co-maintainer on this one:
>
> The SIGNEXTEND macro is no longer used by the MIPS sim code in the
> public sources. (I replaced all uses with uses of EXTENDnn, which IMO
> are preferred since they are sim/common macros and their use eats less
> screen real estate. 8-)
>
> If it's not a problem for you, I'd like to remove the SIGNEXTEND macro
> entirely. (I figure, it might be a problem because maybe you've got
> code in your private mips sim which uses SIGNEXTEND and can't be
> converted to use EXTENDnn.)
>
> What do you think?
Even if it is technically a problem for me, that isn't a reason to not
pull the macro. I don't think it is reasonable for me to hold up a
cleanup like this because it breaks some un-released code.
Yes feel free to commit it.
Andrew