This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: x86-64-tdep.h cleanup
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Michal Ludvig <mludvig at suse dot cz>, gdb-patches at sources dot redhat dot com
- Date: Tue, 5 Mar 2002 09:29:47 -0700
- Subject: Re: x86-64-tdep.h cleanup
- References: <3C84EAA8.2000900@suse.cz>
On Mar 5, 4:56pm, Michal Ludvig wrote:
> As it was recommended by lots of people here I moved <sys/reg.h> along
> with regmap from x86-64-tdep.h to x86-64-linux-nat.c.
> Also to let x86-64-tdep.h contain only #defines, I moved declarations of
> x86_64_linux_frame_saved_pc and x86_64_linux_saved_pc_after_call to
> x86-64-tdep.c. Are these changes OK to commit?
>
> Michal Ludvig
>
> Index: ChangeLog
> from Michal Ludvig <mludvig@suse.cz>
>
> * x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c
> (x86_64_linux_frame_saved_pc,
> x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c
> * x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here
> from x86-64-tdep.h
> * x86-64-tdep.c (x86_64_linux_frame_saved_pc,
> x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h
Michael,
I'm not the maintainer of the files in questions, but your changes
look okay to me.
Make sure your ChangeLog entries are indented by a tab and make sure
that you end your remarks with a period. Also, it's been pointed out
to me in the past that an entry like this:
* x86-64-tdep.c (x86_64_linux_frame_saved_pc,
x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h.
should be written like this instead:
* x86-64-tdep.c (x86_64_linux_frame_saved_pc)
(x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h.
(I've been told that emacs is happier if ChangeLog entries are
formatted this way.)
Kevin