Re: [RFA] gdbserver 1/3 - top level config

[Daniel Jacobowitz <drow at mvista dot com>]

On Wed, Feb 13, 2002 at 11:20:45PM -0500, Andrew Cagney wrote:
> 
> >-# these really aren't orthogonal true/false values of the same condition,
> >-# but shells are slow enough that I like to reuse the test conditions
> >-# whenever possible
> 
> Yes, the comment was silly.
> 
> However a comment indicating that the NATIVE info is picked up from the 
> HOST (.mh) file because there is no NATIVE (.mn) file would be useful.

Is this about what you were looking for?
# We pick this up from the host configuration file (.mh) because we
# do not have a native configuration Makefile fragment.

> > if test "${target}" = "${host}"; then
> > nativefile=`sed -n '
> > s/NAT_FILE[ 	]*=[ 	]*\([^ 	]*\)/\1/p
> > ' ${host_makefile_frag}`
> >-# else
> >-# GDBserver is only useful in a "native" environment
> >-# configdirs=`echo $configdirs | sed 's/gdbserver//'`
> > fi
> > changequote([,])
> > 
> >@@ -1277,10 +1271,16 @@
> >     *)  AC_MSG_ERROR("GDB: Unknown GDB_MULTI_ARCH value ${GDB_MULTI_ARCH}");;
> > esac
> > 
> >-
> > SUBDIRS="doc testsuite nlm"
> > if test "${enable_multi_ice}" = "yes"; then
> >   SUBDIRS="${SUBDIRS} multi-ice"
> >+fi
> 
> >+if test x"${target}" = x"${host}"; then
> >+    if test x"${build_gdbserver}" = xyes ; then
> >+	configdirs="${configdirs} gdbserver"
> >+	SUBDIRS="${SUBDIRS} gdbserver"
> >+    fi
> 
> v.good move.  make it clear that the condition is separate/independant. 
>  Can I again suggest a comment explaining why.  Is it possible to print 
> an info message?

Sure.  Committed with those changes.  The tree will not build for an
hour or so while I commit and check the other parts.  I'll go through
and do NEWS entries in the next day or two, I promise.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer