This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] gdbserver 1/3 - top level config
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 13 Feb 2002 23:20:45 -0500
- Subject: Re: [RFA] gdbserver 1/3 - top level config
- References: <20020205174549.A13231@nevyn.them.org>
> -# these really aren't orthogonal true/false values of the same condition,
> -# but shells are slow enough that I like to reuse the test conditions
> -# whenever possible
Yes, the comment was silly.
However a comment indicating that the NATIVE info is picked up from the
HOST (.mh) file because there is no NATIVE (.mn) file would be useful.
> if test "${target}" = "${host}"; then
> nativefile=`sed -n '
> s/NAT_FILE[ ]*=[ ]*\([^ ]*\)/\1/p
> ' ${host_makefile_frag}`
> -# else
> -# GDBserver is only useful in a "native" environment
> -# configdirs=`echo $configdirs | sed 's/gdbserver//'`
> fi
> changequote([,])
>
> @@ -1277,10 +1271,16 @@
> *) AC_MSG_ERROR("GDB: Unknown GDB_MULTI_ARCH value ${GDB_MULTI_ARCH}");;
> esac
>
> -
> SUBDIRS="doc testsuite nlm"
> if test "${enable_multi_ice}" = "yes"; then
> SUBDIRS="${SUBDIRS} multi-ice"
> +fi
> +if test x"${target}" = x"${host}"; then
> + if test x"${build_gdbserver}" = xyes ; then
> + configdirs="${configdirs} gdbserver"
> + SUBDIRS="${SUBDIRS} gdbserver"
> + fi
v.good move. make it clear that the condition is separate/independant.
Can I again suggest a comment explaining why. Is it possible to print
an info message?
ok with me.
Andrew