This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Do solib address arithmetic with appropriate truncation


On Feb 2,  8:31pm, Jim Blandy wrote:

> Sat Feb  2 17:03:26 2002  Jim Blandy  <jimb@seadog.cygnus.com>
> 
> 	* solib-svr4.c (svr4_truncate_ptr): New function.
> 	(svr4_relocate_section_addresses): Do the address arithmetic with
> 	the appropriate truncation for target addresses, even when
> 	CORE_ADDR is larger than a target address.

I think this is a satisfactory short term (or even mid term) solution.
I think the long term solution will be to introduce a method for adding
offsets to CORE_ADDRs.  See

    http://sources.redhat.com/ml/gdb/2001-10/msg00036.html

I think it's okay to commit this patch, but I'd appreciate it if you'd
add a comment indicating that svr4_truncate_ptr() should be removed
when methods for adding displacements to CORE_ADDRs are introduced.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]