This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: check executable file's timestamp before running



Thanks.  I've committed both the testsuite and the infcmd.c change.

Fernando Nasser <fnasser@redhat.com> writes:
> The new test that detects the bug is approved, of course.
> 
> I can't approve the fix for infcmd.c, but it does look reasonable
> to me.
> 
> Fernando
> 
> Jim Blandy wrote:
> > 
> > It turns out that the logic for rereading debugging info when an
> > executable file has changed is completely separate from the logic for
> > re-opening `exec_bfd', the BFD the `exec' target layer uses for memory
> > reads.
> > 
> > This patch adds a test that detects the bug, and a fix.  The fix seems
> > reasonable, but I'm not sure it's right; there's too much stray state
> > in that portion of GDB for me to really understand.  But it does fix
> > the bug.
> > 
> > gdb/ChangeLog:
> > 2001-12-07  Jim Blandy  <jimb@redhat.com>
> > 
> >         * infcmd.c (run_command): Check that the `exec' target layer's BFD
> >         is up-to-date before running the program, not just when a program
> >         exits.
> > 
> > gdb/testsuite/ChangeLog:
> > 2001-12-07  Jim Blandy  <jimb@redhat.com>
> > 
> >         * gdb.base/reread.exp: Check that GDB properly re-reads the
> >         executable file when it changes while no inferior is running.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]