This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFC: ARM simulator coredump
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: fnf at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com, Richard dot Earnshaw at arm dot com
- Date: Thu, 10 Jan 2002 15:33:18 +0000
- Subject: Re: RFC: ARM simulator coredump
- Organization: ARM Ltd.
- Reply-to: Richard dot Earnshaw at arm dot com
> + int ok = state->CPRead[14] (state, 0, &cp14r0);
As a coding nit, I can't say I'm madly keen on a variable that's called
"ok". At any point other than its assignment, it isn't going to be very
clear what is "ok". This variable is used over more than 50 lines of code
which, at least for me, means that I won't be able to see the assignment
at the same time as it's final use.
R.