This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files

From: Michael Snyder <msnyder at redhat dot com>
To: Andrew Cagney <ac131313 at cygnus dot com>
Cc: thorpej at wasabisystems dot com, Mark Kettenis <kettenis at science dot uva dot nl>, gdb-patches at sourceware dot cygnus dot com
Date: Sat, 05 Jan 2002 12:54:47 -0800
Subject: Re: [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files
Organization: Red Hat, Inc.
References: <20020104160746.H9599@dr-evil.shagadelic.org> <s3i4rm1iqav.fsf@soliton.wins.uva.nl> <20020104190350.K9599@dr-evil.shagadelic.org> <3C3671C2.253B6799@redhat.com> <3C3675C1.8090805@cygnus.com>

Andrew Cagney wrote:
> 
> >  (fill_gregset): Use regcache_collect.
> >
> >
> > Are you concerned about threads?  regcache_collect is not thread-aware.
> 
> I don't think that is a problem here.  The code it is replacing was
> using registers[] directly.  regcache_collect() is definitly less evil
> than registers[] :-)

Definitely.

> Oh, and released versioins of NetBSD don't have kernel level threads.

OK, then it's not an issue.

References:
- [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files
  - From: Jason R Thorpe
- Re: [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files
  - From: Mark Kettenis
- Re: [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files
  - From: Jason R Thorpe
- Re: [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files
  - From: Michael Snyder
- Re: [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files
  - From: Andrew Cagney

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]