This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: port to Sanyo XStormy16 CPU

> Just the usual style things:  can I suggest making macro's like 
>> TYPE_IS_SCALAR functions; can you please put the .c files through 
>> gdb/gdb_indent.sh so it matches GDB's indentation style.
> 
> 
> I've rearranged the macro TYPE_IS_SCALAR() to be a function called
> xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c.
> 
> Thanks for the approval, I've applied everything.


Corinna, thanks.

The next thing is to keep an eye on http://sources.redhat.com/gdb/ari/ 
to see if the files cause any regressions (any should show up tomorrow).

One thing that has already appeared is some file name problems in the 
opcodes directory.  They can be fixed by tweeking 
gdb/config/djgpp/fnchange.lst (?) - the tweek is considered obvious.

enjoy,
Andrew
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]