This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: port to Sanyo XStormy16 CPU


> Corinna
> 
> gdb ChangeLog:
> 
> 2001-12-10  Corinna Vinschen  <vinschen@redhat.com>
> 
> * Makefile.in: Add support for xstormy16.
> 	* configure.tgt: Ditto.
> 	* xstormy16-tdep.c: New file.
> 	* config/xstormy16/xstormy16.mt: New file.
> 
> gdb/testsuite ChangeLog:


Yes.  Your code is fine.  The comments are very much appreciated.

Just the usual style things:  can I suggest making macro's like 
TYPE_IS_SCALAR functions; can you please put the .c files through 
gdb/gdb_indent.sh so it matches GDB's indentation style.


> 2001-12-10  Corinna Vinschen  <vinschen@redhat.com>
> 
> * gdb.asm/asm-source.exp: Add support for xstormy16.
> 	* gdb.asm/configure.in: Ditto.
> 	* gdb.asm/configure: Rebuild.
> 	* gdb.asm/xstormy16.inc: New file.
> 


This bit would follow on as obvious.  Nice to see a target including its 
assembler test case!

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]