This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: patch for remote and install gdb.asm testing
- From: Michael Snyder <msnyder at cygnus dot com>
- To: Geoffrey Keating <geoffk at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 10 Dec 2001 11:22:14 -0800
- Subject: Re: patch for remote and install gdb.asm testing
- Organization: Red Hat, Inc.
- References: <200112082149.fB8Lnea20907@thief.cygnus.com>
Geoffrey Keating wrote:
>
> This patch fixes the asm-source.exp testcase so that it:
> - Doesn't need configure; and
> - Works on a remote host.
>
> I've tested it on x86-linux, where all the tests pass.
And I assume that you've also tested it on a remote host, in which case
> OK to commit?
Yes, please commit it.
Thanks.
> ===File ~/patches/gdb-remoteasmtest.patch===================
> 2001-11-29 Geoffrey Keating <geoffk@redhat.com>
>
> * gdb.asm/asm-source.exp: Download the .inc files to a remote host;
> don't require symlinks or configure.
> * gdb.asm/configure.in: Don't do anything interesting.
> * gdb.asm/configure: Regenerate.
>
> Index: gdb.asm/asm-source.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> retrieving revision 1.12
> diff -p -u -p -r1.12 asm-source.exp
> --- asm-source.exp 2001/12/07 02:50:02 1.12
> +++ asm-source.exp 2001/12/08 21:44:15
> @@ -35,6 +35,12 @@ set asm-arch ""
> set asm-flags ""
> set link-flags ""
>
> +if [is_remote host] {
> + set asm-include "-I."
> +} else {
> + set asm-include "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
> +}
> +
> if [istarget "d10v-*-*"] then {
> set asm-arch d10v
> }
> @@ -60,8 +66,15 @@ set src1 ${srcdir}/${subdir}/asmsrc1.s
> set src2 ${srcdir}/${subdir}/asmsrc2.s
>
> if { "${asm-flags}" == "" } {
> - #set asm-flags "-Wa,-gstabs,-I${srcdir}/${subdir},-I${objdir}/${subdir}"
> - set asm-flags "-gstabs -I${srcdir}/${subdir} -I${objdir}/${subdir}"
> + #set asm-flags "-Wa,-gstabs ${asm-include}"
> + set asm-flags "-gstabs ${asm-include}"
> +}
> +
> +if [ is_remote host ] {
> + remote_download host ${srcdir}/${subdir}/common.inc common.inc
> + remote_download host ${srcdir}/${subdir}/${asm-arch}.inc arch.inc
> +} else {
> + file copy -force ${srcdir}/${subdir}/${asm-arch}.inc ${objdir}/${subdir}/arch.inc
> }
>
> if {[target_assemble ${src1} asmsrc1.o "${asm-flags}"] != ""} then {
> Index: gdb.asm/configure.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
> retrieving revision 1.6
> diff -p -u -p -r1.6 configure.in
> --- configure.in 2001/12/01 01:13:27 1.6
> +++ configure.in 2001/12/08 21:44:15
> @@ -12,15 +12,4 @@ AC_SUBST(CC)
> AC_CONFIG_AUX_DIR(`cd $srcdir;pwd`/../../..)
> AC_CANONICAL_SYSTEM
>
> -dnl In default case we need to link with some file so use common.inc.
> -archinc=common.inc
> -case ${target} in
> -d10v-*-*) archinc=d10v.inc ;;
> -s390-*-*) archinc=s390.inc ;;
> -i[[3456]]86*) archinc=i386.inc ;;
> -m32r*-*) archinc=m32r.inc ;;
> -sparc-*-*) archinc=sparc.inc ;;
> -esac
> -AC_LINK_FILES($archinc,arch.inc)
> -
> AC_OUTPUT(Makefile)
> ============================================================