This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

RE: [patch] H8300 simulator and H8S extensions


Hi Andrew,

> I added some fixes: 
> 1) H8/S is new target (no more synonym of H8/300H)
> 2) insert H8/S mnemonics: eepmov, ldc, stc, tas in simulator
> 3) add EXR for H8/S in all places, where I think it needed.
> 4) correct all control regs opcodes in opcode/h8300.h

Great!

I am not in the position of approving anything, but I think the patch
contains so many things that the maintainer would have hard time
reviewing it.  Why don't you separate the patch into several stages?
For example, you could first submit a patch that replaces literals
with appropriate macros like:

-    case 8:
+    case CCR_REGNUM:

The GNU projects might prefer to have a little more spaces like
"foo (a, b + c)" instead of "foo(a,b+c)".

If I can be of some help, please let me know.

Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]