Re: [PATCH]: testsuite/gdb.base/recurse.exp: Allow passing of `delete watchpoint' test also in epilogue

[Fernando Nasser <fnasser at redhat dot com>]

Approved with the condition of the change being documented (your
analysis 
on the gdb list is excellent).

One option would be make that text a (large) comment and include it in
the
test file.  But I think it would be better to create a Gnats bug report 
as "GDB does not know about function epilogues (and it should)", include
your text there as an example of how it would be useful and add a
comment 
to the test file with a reference to this Gnats entry and a short text
like:

"Pattern was adjusted to account for targets where GDB considers that
the
scope has been exited while still in the function epilogue".

Thank you for the patch.

Regards,
Fernando


Corinna Vinschen wrote:
> 
> Hi,
> 
> according to my description on the gdb mailinglist
> (thread "Testsuite recurse.exp: Leaving scope of watchpoint test fails")
> I want to propose the short-term solution which allows the
> test to pass even when gdb is still in the function's epilogue.
> 
> 2001-09-14  Corinna Vinschen  <vinschen@redhat.com>
> 
>         * gdb.base/recurse.exp: When checking leaving the watchpoint
>         scope, recognize when gdb is in function's epilogue and pass.
> 
> Index: recurse.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/recurse.exp,v
> retrieving revision 1.24
> diff -u -p -r1.24 recurse.exp
> --- recurse.exp 2001/03/26 19:55:26     1.24
> +++ recurse.exp 2001/09/14 09:17:04
> @@ -125,7 +125,7 @@ proc recurse_tests {} {
> 
>         # Continue again.  We should have a watchpoint go out of scope now
>         if [gdb_test "continue" \
> -           "Continuing.*\[Ww\]atchpoint.*deleted.*main \\(\\) .*" \
> +           "Continuing.*\[Ww\]atchpoint.*deleted.*\(main \\(\\) \|21.*\}\).*" \
>             "first instance watchpoint deleted when leaving scope"] then {
>             gdb_suppress_tests;
>         }
> 
> Corinna
> 
> --
> Corinna Vinschen
> Cygwin Developer
> Red Hat, Inc.
> mailto:vinschen@redhat.com

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9