This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] mips argument passing fixes for o32
On Fri, Jul 20, 2001 at 06:20:46PM -0400, Andrew Cagney wrote:
> Daniel,
>
> Just to close this current thread. For the moment I'm rejecting the change:
>
> > if (!MIPS_EABI
> > && MIPS_SAVED_REGSIZE < 8
> > - && TARGET_BYTE_ORDER == BIG_ENDIAN
> > + && (TARGET_BYTE_ORDER == BIG_ENDIAN
> > + || TYPE_LENGTH (arg_type) < MIPS_SAVED_REGSIZE)
> > && partial_len < MIPS_SAVED_REGSIZE
> > && (typecode == TYPE_CODE_STRUCT ||
> > typecode == TYPE_CODE_UNION))
>
> I need hard evidence (not comments from GCC) that LE o32 does indead
> left shift small register structs. I'll probably eventually get that
> evidence however, until then I'd prefer to drop this change.
What should I do about the test in the meantime? I don't have access
to any other LE o32 compilers besides GCC, so I can't help you with
that, and just leaving the FAIL seems inadequate. I suppose I could
XFAIL it.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer