This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [rfa] mips argument passing fixes for o32

To: Andrew Cagney <ac131313 at cygnus dot com>
Subject: Re: [rfa] mips argument passing fixes for o32
From: Andrew Cagney <ac131313 at cygnus dot com>
Date: Fri, 20 Jul 2001 18:20:46 -0400
Cc: Daniel Jacobowitz <dmj+ at andrew dot cmu dot edu>,gdb-patches at sources dot redhat dot com
References: <20010706112635.A5870@nevyn.them.org> <3B4D5E95.6010407@cygnus.com> <20010712103946.C6359@nevyn.them.org> <3B4DF3A9.8010205@cygnus.com>

Daniel,

Just to close this current thread.  For the moment I'm rejecting the change:

> if (!MIPS_EABI
>                && MIPS_SAVED_REGSIZE < 8
> -              && TARGET_BYTE_ORDER == BIG_ENDIAN
> +              && (TARGET_BYTE_ORDER == BIG_ENDIAN
> +              || TYPE_LENGTH (arg_type) < MIPS_SAVED_REGSIZE)
>                && partial_len < MIPS_SAVED_REGSIZE
>                && (typecode == TYPE_CODE_STRUCT ||
>                typecode == TYPE_CODE_UNION))

I need hard evidence (not comments from GCC) that LE o32 does indead 
left shift small register structs.  I'll probably eventually get that 
evidence however, until then I'd prefer to drop this change.

	Andrew

Follow-Ups:
- Re: [rfa] mips argument passing fixes for o32
  - From: Daniel Jacobowitz

References:
- [rfa] mips argument passing fixes for o32
  - From: Daniel Jacobowitz
- Re: [rfa] mips argument passing fixes for o32
  - From: Andrew Cagney
- Re: [rfa] mips argument passing fixes for o32
  - From: Daniel Jacobowitz
- Re: [rfa] mips argument passing fixes for o32
  - From: Andrew Cagney

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]