This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fix m68k-linux build


> I don't have the hardware to test this, but by (exact) analogy with all the
> other Linux ports, I'm pretty sure it's correct.  And yes, I intend to
> eliminate all these copies of fetch_core_registers in one fell swoop some
> day soon...


Most of the patch falls into the obvious category and can just go 
straight in.  As you note, there is no maintainer.

For the ChangeLog, could I suggest a form like:

YYYY-MM-DD <you>


	From Michael Fedrowitz  <michael.fedrowitz@informatik.uni-ulm.de>:

	* m68klinux-nat.c: Fix comment.
	(supply_gregset): Change argument to elf_gregset_t *.
	(supply_fpregset): Change argument to elf_fpregset_t *.


		From ....:
		change-log


it makes checking on changes much easier.

>  (fetch_core_registers): New function.


Separatly.
Could you please add a comment to the code explaining where the function 
was copied from (Or better bypass this step and rationalize those 
functions :-).

	Andrew





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]