This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] The MIPS/Linux port
- To: Daniel Jacobowitz <dmj+ at andrew dot cmu dot edu>
- Subject: Re: [RFA] The MIPS/Linux port
- From: Mark Kettenis <kettenis at science dot uva dot nl>
- Date: 04 Jul 2001 23:51:27 +0200
- Cc: gdb-patches at sources dot redhat dot com
- References: <20010704121952.A17445@nevyn.them.org>
Looks like the MIPS port was started before a bit of reformatting of
the sources and conversion to ISO C took place. Please
* Format the copyright notice at the beginning of the file as all
(most of) the other files, for example i386-linux-tdep.c.
* Don't put a start on every line of multi-line comments.
* Put two spaces after a full stop (.) in comments, even at the end
of the comment. Make the comments full senteces, including a full
stop at the end of them.
* Wrap long comments.
* Use ISO C prototypes and function definitions, e.g.
int
get_longjmp_target (CORE_ADDR *pc)
{
and
static void fetch_core_registers (char *, unsigned, int, CORE_ADDR);
(get rid of PARAMS).
Good luck!
Mark