This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] bfd/rs6000-core.c

To: Nick Duffek <nsd at redhat dot com>, dje at watson dot ibm dot com
Subject: Re: [PATCH] bfd/rs6000-core.c
From: Kevin Buettner <kevinb at cygnus dot com>
Date: Tue, 26 Jun 2001 09:21:17 -0700
Cc: china at thewrittenword dot com, gdb-patches at sources dot redhat dot com, kevinb at redhat dot com
References: <200106240523.BAA24138@makai.watson.ibm.com> <200106251820.f5PIKY225156@rtl.cygnus.com>

On Jun 25,  2:20pm, Nick Duffek wrote:

> On 24-Jun-2001, David Edelsohn wrote:
> 
> >	* rs6000-core.c: Use autoconf variable HAVE_ST_C_IMPL to guard use
> >	of c_impl field.
> >	* configure.in: Auto-configure HAVE_ST_C_IMPL.
> >	* configure.in: Likewise.
> 
> The patch looks good to me.  Approved, unless Kevin has any objections.

I've just looked it over and it looks good to me too.

> I suggest also getting the binutils mailing list to rubber-stamp it before
> committing it.  There was talk about officially giving GDB ownership of
> GDB-only files in bfd, but I don't think that's happened.

I agree that it ought to be sent to the binutils list prior to committing
it.

Kevin

Follow-Ups:
- Re: [PATCH] bfd/rs6000-core.c
  - From: David Edelsohn

References:
- [PATCH] bfd/rs6000-core.c
  - From: David Edelsohn
- Re: [PATCH] bfd/rs6000-core.c
  - From: Nick Duffek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]