This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] breakpoint.c: don't generate bp events for internal bps
- To: Keith Seitz <keiths at cygnus dot com>
- Subject: Re: [RFA] breakpoint.c: don't generate bp events for internal bps
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Fri, 11 May 2001 21:56:26 -0400
- Cc: gdb-patches at sources dot redhat dot com
- References: <Pine.GSO.4.33.0105102023220.29679-100000@ryobi.cygnus.com>
Keith,
I think the patch is filtering things at the wrong level. If Insight
doesn't want to know about certain breakpoints then it should discard them.
You probably also want to check ui-out.h and defs.h:gdb_breakpoint_query().
Andrew
> +/* Is this breakpoint interesting to a user interface? */
> +#define REPORT_BREAKPOINT_EVENT(bp) \
> +((bp)->type == bp_breakpoint \
> + || (bp)->type == bp_hardware_breakpoint \
> + || (bp)->type == bp_watchpoint \
> + || (bp)->type == bp_hardware_watchpoint \
> + || (bp)->type == bp_read_watchpoint \
> + || (bp)->type == bp_access_watchpoint)
> +
> /* Set breakpoint count to NUM. */
BTW, macro's are bad, M'kay!
Andrew