This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH RFC] process/thread/lwp id patch - phase 1


On May 3, 10:20am, Eli Zaretskii wrote:

> > MERGEPID will be defined for all ports and all targets since it is
> > defined later on in defs.h...
> > 
> > #ifndef PIDGET
> > #define PIDGET(PID) (PID)
> > #define TIDGET(PID) 0
> > #define MERGEPID(PID, TID) (PID)
> > #endif
> 
> Hmm, I don't see this snippet in defs.h in the patch you posted.

It wasn't in the patch I posted.  It already exists in defs.h.

> > Also, MERGEPID is defined along with PIDGET in each each header file
> > where PIDGET is defined.  These are:
> > 
> >     config/nm-linux.h
> >     config/sparc/tm-sun4sol2.h
> >     config/i386/tm-i386sol2.h
> >     config/i386/tm-i386v42mp.h
> 
> These I do see, but they are specific to these targets.  MERGEPID
> seems to be required on all targets.

Yes.  If one of those four (target specific) header files doesn't
define MERGEPID, then it'll get defined by the (already existing)
define in defs.h.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]