Re: [RFA]: simulator build failures with parallel make

[Andrew Cagney <ac131313 at cygnus dot com>]

"J.T. Conklin" wrote:
> 
> With gmake -j, the d10v, mn10200, mn10300 and v850 simulators can
> fail to build because the generated header simops.h is included by
> simops.c, but is not listed as a dependency for that file.
> 
> There are similar failures with the ppc simulator.  I'll submit a
> patch for it as soon as I get a few moments to address it.
> 
>         --jtc
> 
> (I have this change log entry in each of the four simulator directories)
> 
> 2001-03-27  J.T. Conklin  <jtc@redback.com>
> 
>         * Makefile.in (simops.o): Add simops.h to dependency list.

With that dependency added without -j does the generator get run twice?
I've this memory of a strange querk with make dependencies and files
being created as a sideeffect.

Any way, assuming you've played with it with using both make and gmake
and it appears ok then yes.

	Andrew

> Index: d10v/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/sim/d10v/Makefile.in,v
> retrieving revision 1.2
> diff -c -r1.2 Makefile.in
> *** Makefile.in 2000/02/22 08:52:21     1.2
> --- Makefile.in 2001/03/27 20:07:40
> ***************
> *** 48,53 ****
>         rm -f table.c simops.h gencode
> 
>   interp.o: interp.c table.c $(INCLUDE)
> ! simops.o: simops.c $(INCLUDE)
>   endian.o: endian.c $(INCLUDE)
>   table.o: table.c
> --- 48,53 ----
>         rm -f table.c simops.h gencode
> 
>   interp.o: interp.c table.c $(INCLUDE)
> ! simops.o: simops.c simops.h $(INCLUDE)
>   endian.o: endian.c $(INCLUDE)
>   table.o: table.c
> Index: mn10200/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/sim/mn10200/Makefile.in,v
> retrieving revision 1.1.1.2
> diff -c -r1.1.1.2 Makefile.in
> *** Makefile.in 1999/04/26 18:33:09     1.1.1.2
> --- Makefile.in 2001/03/27 20:07:40
> ***************
> *** 48,52 ****
>         rm -f table.c simops.h gencode
> 
>   interp.o: interp.c table.c $(INCLUDE)
> ! simops.o: simops.c $(INCLUDE)
>   table.o: table.c
> --- 48,52 ----
>         rm -f table.c simops.h gencode
> 
>   interp.o: interp.c table.c $(INCLUDE)
> ! simops.o: simops.c simops.h $(INCLUDE)
>   table.o: table.c
> Index: mn10300/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/sim/mn10300/Makefile.in,v
> retrieving revision 1.2
> diff -c -r1.2 Makefile.in
> *** Makefile.in 2000/03/03 23:25:10     1.2
> --- Makefile.in 2001/03/27 20:07:40
> ***************
> *** 152,158 ****
> 
> 
>   interp.o: interp.c $(MN10300_INTERP_DEP) $(INCLUDE)
> ! simops.o: simops.c $(INCLUDE)
>   table.o: table.c
> 
>   clean-extra: clean-igen
> --- 152,158 ----
> 
> 
>   interp.o: interp.c $(MN10300_INTERP_DEP) $(INCLUDE)
> ! simops.o: simops.c simops.h $(INCLUDE)
>   table.o: table.c
> 
>   clean-extra: clean-igen
> Index: v850/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/sim/v850/Makefile.in,v
> retrieving revision 1.3
> diff -c -r1.3 Makefile.in
> *** Makefile.in 2001/03/14 21:51:31     1.3
> --- Makefile.in 2001/03/27 20:07:41
> ***************
> *** 135,140 ****
>         rm -f table.c simops.h gencode
> 
>   #interp.o: interp.c table.c $(INCLUDE)
> ! simops.o: simops.c $(INCLUDE) targ-vals.h
>   #table.o: table.c
>   semantics.o: $(INCLUDE)
> --- 135,140 ----
>         rm -f table.c simops.h gencode
> 
>   #interp.o: interp.c table.c $(INCLUDE)
> ! simops.o: simops.c simops.h $(INCLUDE) targ-vals.h
>   #table.o: table.c
>   semantics.o: $(INCLUDE)