Re: [PATCH RFA] New testsuite test: step-line.exp

[Fernando Nasser <fnasser at redhat dot com>]

Kevin Buettner wrote:
> 
> This test will cause 12 new FAILs when run against a current GDB.
> These 12 FAILs go away when my symtab.c patch is applied.  See:
> 

Kevin,

I was waiting for the approval of your symtab patch...

While we wait for that, I will conditionally approve this patch.
The conditions are the following:

1) You only check it in when you check your symtab patch in.
2) Make these simple additions to the ChangeLog entries (see below).


From:
>         * gdb.base/Makefile.in (EXECUTABLES): Add step-line.
>         * gdb.base/step-line.c: New file.
>         * gdb.base/step-line.exp: New file.
>         * gdb.base/step-line.inp: New file.


To:
	* gdb.base/Makefile.in (EXECUTABLES): Add step-line.
	* gdb.base/step-line.exp: New file.  Test step/next in presence of
	#line directives.
	* gdb.base/step-line.c: New file.  Test program for the above.
	* gdb.base/step-line.inp: New file.  We pretend that this file has
	been transformed by some other tool into step-line.c.


Thanks for writing the test.

Regards,
Fernando


P.S.: In the comment inside step-line.exp there is a typo.  It reads
"Test stepping in files in with #line directives.".  There are thow 'in'
in the sentence.


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9