This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA]: Remove unused header files.


>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
>> Yes and no.  If I was linting GDB configured for the mn10200, it
>> regcache.h would be considered necessary, but for other cases it
>> would not.  Since I'm not planning on linting every possible config
>> before deciding whether a header is unnecessary, it's not up to the
>> job.

Andrew> I think we need to clarify one of the ground rules - should
Andrew> "tm.h" et.al. files be sucking in the things they refer to and
Andrew> (assuming that is agreed) should that be addressed before
Andrew> include headers are eliminated from .c files.

Andrew> If that isn't done, I've the (rational) fear that these
Andrew> cleanups will start breaking an unreasonable number of
Andrew> existing targets.  Rational?  Well I'm still cleaning up
Andrew> fallout from regcache.h - I've ~50 tm.h files that should
Andrew> include regcache.h.

I think you know my position already.  I think it is reasonable to
require that tm-, nm-, and xm- headers to include any headers that
contain definitions, declarations, etc. that are needed.  

As a result, this lifts the requirement that all modules must include
all header files that any (of the zillion) tm-, nm-, or xm- header
depends on.

        --jtc

-- 
J.T. Conklin
RedBack Networks


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]