This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] "maint print psymbols" with large section tables
- To: Michael Elizabeth Chastain <chastain at cygnus dot com>
- Subject: Re: [RFA] "maint print psymbols" with large section tables
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Date: Thu, 1 Mar 2001 10:44:40 +0200 (IST)
- cc: gdb-patches at sourceware dot cygnus dot com
On Wed, 28 Feb 2001, Michael Elizabeth Chastain wrote:
> This patch fixes "maint print psymbols" to work better with large
> section offset tables. The existing code prints the whole section offset
> tale all on one line, which is awkward when a section offset table has
> 900+ entries. (The code thinks it is wrapping lines, but wrap_here()
> does no good when all the output is going to outfile).
>
> The existing code also takes so long to execute that I saw timeout
> failures in gdb.base/maint.exp. This is my motivation for changing
> the code.
>
> The new code prints only the non-zero entries of a section offset table,
> one per line.
I don't like removing features, unless we know for a fact that no one
uses them. In my experience, many times a feature is requested
shortly after it is removed ;-)
Is it possible that someone would want to see the zero entries as
well? If so, I think we should at least leave behind some option that
could be used to see all the entries, albeit in a different format
(one per line).
Also, if this patch is accepted, please update the docs of "maint print
psymbols" in gdb.texinfo. It should at least say that zero entries are
skipped.