This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] gdb testsuite changes


    From: Michael Elizabeth Chastain <chastain@cygnus.com>
    Date: Tue, 27 Feb 2001 19:42:44 -0800

    I proofread this.

    > * gdb.base/annota1.exp: Move test of isnative to earlier in the
    > file -- to prevent failing when the compile fails but we have no
    > intention of running the tests anyway.

    I don't really object to this, but I am curious why the compile fails.
    The test script doesn't run on targets but the reason for that is
    unrelated to compiling the test program.

    Please update the copyright date in this file.

I meant to update the copyright on all the files; thanks for catching
it.

As to why the compile fails, if memory serves -- the link fails with
some undefined symbols for the embedded target that motivated the
change.

    > * gdb.c++/ctti.exp: Skip tests if skip_cplus_tests returns true.
    > * gdb.c++/namespace.exp: Ditto.

    Cool, this fixes PR gdb/16.  You can say "Fix gdb/16" in ChangeLog
    if you want.

    Testing: I tested this on a Red Hat Linux 7 native system with FSF gcc
    cvs gcc-3_0-branch dated 2001-01-27 and FSF gdb cvs dated 2001-01-27.
    I hand inspected gdb.log for the affected files and found no problems.

    I also twiddled "no_long_long" and "skip_cplus_tests" one at a time
    and watched the suppression logic work properly.

    > Okay to commit?

    I recommend approval, but I do not have authority.

    Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]