This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH RFC] Update/correct copyright notices


Proofread.  Several glitches found.

Michael

===

gdb/config/i386/xm-ptx4.h has a formatting problem.

  diff -upr gdb.orig/config/i386/xm-ptx4.h gdb/config/i386/xm-ptx4.h
  --- gdb.orig/config/i386/xm-ptx4.h      Wed Jul  7 13:13:44 1999
  +++ gdb/config/i386/xm-ptx4.h   Wed Feb 28 01:17:13 2001
  @@ -1,6 +1,6 @@
   /* Definitions to make GDB run on a Sequent Symmetry under ptx, with
  -   Weitek 1167 and i387 support.  Copyright 1986, 1987, 1989, 1992,
  -   1993 Free Software Foundation, Inc.
  +   Weitek 1167 and i387 support.  Copyright 1986, 1987, 1989, 1992, 1993,
  +   Weitek 1167 and i387 support.  1994 Free Software Foundation, Inc.
   
      This file is part of GDB.
   
gdb/mipsread.c dropped some years.  According to the CVS log and the
ChangeLog, this file was edited on 2001-02-10, but "2001" was dropped.
The file is also mentioned in ChangeLog-1998, but "1998" was dropped.

  diff -upr gdb.orig/mipsread.c gdb/mipsread.c
  --- gdb.orig/mipsread.c Thu Feb 15 19:58:01 2001
  +++ gdb/mipsread.c      Wed Feb 28 01:17:14 2001
  @@ -1,5 +1,6 @@
   /* Read a symbol table in MIPS' format (Third-Eye).
  -   Copyright 1986, 87, 89, 90, 91, 92, 93, 94, 95, 96, 1998, 2001
  +   Copyright 1986, 1987, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996,
  +   1999, 2000
      Free Software Foundation, Inc.
      Contributed by Alessandro Forin (af@cs.cmu.edu) at CMU.  Major work
      by Per Bothner, John Gilmore and Ian Lance Taylor at Cygnus Support.

gdb/thread.c changed the nominal copyright owner!  The old file has no
mention of "Free Software Foundation, Inc."  The new file has no mention
of "Lynx Real-Time Systems, Inc.  Los Gatos, CA."  I recommend that
we specifically check that Lynx has an assignment on file that covers
gdb/thread.c, and then make sure that their "Contributed by ..." line
comes after the "Copyright Free Software Foundation, Inc." line.

  diff -upr gdb.orig/thread.c gdb/thread.c
  --- gdb.orig/thread.c   Mon Jan 29 17:06:26 2001
  +++ gdb/thread.c        Wed Feb 28 01:17:14 2001
  @@ -1,7 +1,6 @@
   /* Multi-process/thread control for GDB, the GNU debugger.
  -   Copyright 1986, 1987, 1988, 1993, 1998, 1999, 2000, 2001
  -
  -   Contributed by Lynx Real-Time Systems, Inc.  Los Gatos, CA.
  +   Copyright 1986, 1987, 1988, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
  +   2000, 2001
      Free Software Foundation, Inc.
   
      This file is part of GDB.

gdb/nindy-share/* is problematic.  Changelog-1993 says:

  * nindy-share/*, remote-nindy.c: Extensive hacking to make it
    conform to GDB conventions like using memcpy not bcopy, serial.h,
    etc.  This is to make it host on Solaris, AIX, etc.

... so these files will need hand analysis.

I grepped for '\/\*' in ChangeLog-* and ChangeLog and found some more
instances of this.   I recomend hand-checking for this problem in a
subsequent task.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]