This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] info_sharedlibrary_command patch
- To: "Martin M. Hunt" <hunt at redhat dot com>, <gdb-patches at sources dot redhat dot com>
- Subject: Re: [RFA] info_sharedlibrary_command patch
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Mon, 19 Feb 2001 19:35:48 -0700
- References: <Pine.SUN.4.33.0102191649590.2670-100000@rtl.cygnus.com>
On Feb 19, 4:52pm, Martin M. Hunt wrote:
> info_sharedlibrary_command() currently casts all addresses to long before
> printing them. Obviously this fails if pointers are larger than longs.
>
> 2001-02-19 Martin M. Hunt <hunt@redhat.com>
>
> * solib.c (info_sharedlibrary_command): Don't assume pointers
> are the same size of long, call longest_local_hex_string_custom().
Approved.
I was looking at this one myself a while back, but got bogged down on
whether to use longest_local_hex_string_custom() or paddr(). See
http://sources.redhat.com/ml/gdb/2000-10/msg00090.html. For now, your
change is fine.
Kevin