This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC] Accomodate 64-bit msymbols in expressions
- To: Kevin Buettner <kevinb at cygnus dot com>
- Subject: Re: [RFC] Accomodate 64-bit msymbols in expressions
- From: Michael Snyder <msnyder at cygnus dot com>
- Date: Fri, 16 Feb 2001 16:32:32 -0800
- CC: gdb-patches at sources dot redhat dot com, keiths at redhat dot com, kevinb at redhat dot com
- Organization: Red Hat
- References: <3A8DBFEF.45B230C1@cygnus.com> <1010217003055.ZM12822@ocotillo.lan>
Kevin Buettner wrote:
>
> On Feb 16, 4:03pm, Michael Snyder wrote:
>
> > The following change is motivated by the fact that the addresses of
> > minimal symbols currently get truncated to 32 bits in expressions.
> >
> > Does this look badly wrong to anybody?
>
> Not badly wrong. The only nit that I can pick is...
>
> > ! /* Let's make the type big enough to hold a 64-bit address. */
> > ! write_exp_elt_type (builtin_type_long_long);
>
> ...that it might be preferable to use builtin_type_CORE_ADDR instead.
>
> (I.e, think about what happens if TARGET_LONG_LONG_BIT == 32, but
> TARGET_ADDR_BIT == 64.)
That's a good idea. Thanks.